S19: consume versioned engineering resources and move landscape documentation
All checks were successful
Build, test and publish / verify (push) Successful in 8m54s
All checks were successful
Build, test and publish / verify (push) Successful in 8m54s
This commit is contained in:
@@ -1,19 +1,10 @@
|
||||
# Backend review companion
|
||||
# Agile Dancers backend review companion
|
||||
|
||||
Use alongside `skills/code-review/SKILL.md` and `CODING_STANDARDS.md`.
|
||||
Use [the shared review guidance](../generated/docs/backend-review.md),
|
||||
[code-review skill](../generated/skills/code-review/SKILL.md), and
|
||||
[project standards](../CODING_STANDARDS.md).
|
||||
|
||||
Review changed code for intent-revealing comments, missing public-contract Javadoc,
|
||||
appropriate record use, defensive copying of mutable record components, and
|
||||
compatibility with APIs, JSON and persistence. Assess ambiguous `var` initializers
|
||||
and framework/lifecycle exceptions to field finality. Confirm architecture and
|
||||
injection decisions make sense for production and tests. Check NIO API preference,
|
||||
varargs for trailing array parameters, and Java 25 IO use for direct console
|
||||
input/output; retain System.err for diagnostics. Require Javadoc for public
|
||||
classes and methods beyond basic POJO/data-carrier behavior.
|
||||
|
||||
Read standards reports even when verification passes. Assess every review signal
|
||||
in changed code, including fan-out, public methods and record component counts.
|
||||
Record a rationale for retained signals in the S7 evidence or change description.
|
||||
Check narrowly scoped waivers against recorded maintainer agreement and reason.
|
||||
Never introduce blanket exclusions or weaken thresholds to pass a build.
|
||||
Do not repeat mechanical checks already enforced by tooling; verify their result.
|
||||
The backend module is agiledancers-be. The approved Group constructor waiver
|
||||
remains application-owned in tooling/standards/waivers.tsv. Assess retained
|
||||
signals against the implementation evidence in docs/validation and the change
|
||||
description. S19 introduces no standards waiver.
|
||||
|
||||
Reference in New Issue
Block a user