Wanja Krah
c6a495a93c
All checks were successful
Build, test and publish / verify (push) Successful in 8m54s
20 lines
1.2 KiB
Markdown
20 lines
1.2 KiB
Markdown
# Backend review companion
|
|
|
|
Use alongside `generated/skills/code-review/SKILL.md` and `generated/CODING_STANDARDS.md`.
|
|
|
|
Review changed code for intent-revealing comments, missing public-contract Javadoc,
|
|
appropriate record use, defensive copying of mutable record components, and
|
|
compatibility with APIs, JSON and persistence. Assess ambiguous `var` initializers
|
|
and framework/lifecycle exceptions to field finality. Confirm architecture and
|
|
injection decisions make sense for production and tests. Check NIO API preference,
|
|
varargs for trailing array parameters, and Java 25 IO use for direct console
|
|
input/output; retain System.err for diagnostics. Require Javadoc for public
|
|
classes and methods beyond basic POJO/data-carrier behavior.
|
|
|
|
Read standards reports even when verification passes. Assess every review signal
|
|
in changed code, including fan-out, public methods and record component counts.
|
|
Record a rationale for retained signals in application validation evidence or the change description.
|
|
Check narrowly scoped waivers against recorded maintainer agreement and reason.
|
|
Never introduce blanket exclusions or weaken thresholds to pass a build.
|
|
Do not repeat mechanical checks already enforced by tooling; verify their result.
|